Skip to content

Conversation

@MisterRaindrop
Copy link
Contributor

@MisterRaindrop MisterRaindrop commented Aug 22, 2025

avro schema add sanitize field name issue #192

@wgtmac
Copy link
Member

wgtmac commented Aug 23, 2025

Please add test cases. Thanks!

@MisterRaindrop
Copy link
Contributor Author

Please add test cases. Thanks!

Ok

@MisterRaindrop
Copy link
Contributor Author

MisterRaindrop commented Aug 24, 2025

@wgtmac Hi, cpp-linter report an error, maybe I forgot to open an issue cause it. Can you retry it? Thanks!

INFO:CPP Linter:0 clang-format-checks-failed
  INFO:CPP Linter:1 clang-tidy-checks-failed
  INFO:CPP Linter:1 checks-failed
  ERROR:CPP Linter:response returned 403 from POST https://api.github.com/repos/apache/iceberg-cpp/issues/190/comments with message: {"message":"Resource not accessible by integration","documentation_url":"https://docs.github.com/rest/issues/comments#create-an-issue-comment","status":"403"}
  Traceback (most recent call last):
    File "/home/runner/work/_actions/cpp-linter/cpp-linter-action/f91c446a32ae3eb9f98fef8c9ed4c7cb613a4f8a/venv/bin/cpp-linter", line 8, in <module>
      sys.exit(main())
    File "/home/runner/work/_actions/cpp-linter/cpp-linter-action/f91c446a32ae3eb9f98fef8c9ed4c7cb613a4f8a/venv/lib/python3.10/site-packages/cpp_linter/__init__.py", line 81, in main
      rest_api_client.post_feedback(files=files, args=args, clang_versions=clang_versions)
    File "/home/runner/work/_actions/cpp-linter/cpp-linter-action/f91c446a32ae3eb9f98fef8c9ed4c7cb613a4f8a/venv/lib/python3.10/site-packages/cpp_linter/rest_api/github_api.py", line 264, in post_feedback
      self.update_comment(
    File "/home/runner/work/_actions/cpp-linter/cpp-linter-action/f91c446a32ae3eb9f98fef8c9ed4c7cb613a4f8a/venv/lib/python3.10/site-packages/cpp_linter/rest_api/github_api.py", line 361, in update_comment
      self.api_request(url=comments_url, method=req_meth, data=payload)
    File "/home/runner/work/_actions/cpp-linter/cpp-linter-action/f91c446a32ae3eb9f98fef8c9ed4c7cb613a4f8a/venv/lib/python3.10/site-packages/cpp_linter/rest_api/__init__.py", line 124, in api_request
      response.raise_for_status()
    File "/home/runner/work/_actions/cpp-linter/cpp-linter-action/f91c446a32ae3eb9f98fef8c9ed4c7cb613a4f8a/venv/lib/python3.10/site-packages/requests/models.py", line 1026, in raise_for_status
      raise HTTPError(http_error_msg, response=self)
  requests.exceptions.HTTPError: 403 Client Error: Forbidden for url: https://api.github.com/repos/apache/iceberg-cpp/issues/190/comments
  Error: Process completed with exit code 1.

@wgtmac
Copy link
Member

wgtmac commented Aug 24, 2025

image

You need to go to the files page to check specific linter errors.

@MisterRaindrop MisterRaindrop force-pushed the liuxiaoyu/sanitized_field_name branch from 8339497 to 51f205c Compare August 30, 2025 02:05
@wgtmac
Copy link
Member

wgtmac commented Sep 3, 2025

Let me know when it is ready to review. Thanks!

@MisterRaindrop
Copy link
Contributor Author

Let me know when it is ready to review. Thanks!

You can review thanks

@MisterRaindrop
Copy link
Contributor Author

@wgtmac You can review thanks

@MisterRaindrop
Copy link
Contributor Author

@wgtmac can review, thanks

Copy link
Member

@wgtmac wgtmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @MisterRaindrop!

@wgtmac
Copy link
Member

wgtmac commented Sep 23, 2025

@Fokko Could you help review and merge this? Thanks!

@Fokko Fokko merged commit 1cea1e9 into apache:main Sep 25, 2025
7 checks passed
@Fokko
Copy link
Contributor

Fokko commented Sep 25, 2025

Thanks @MisterRaindrop 🙏 and thanks everyone for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants